On 25-06-14 17:57, Johannes Berg wrote:
On Tue, 2014-06-24 at 19:21 +0200, Arend van Spriel wrote:
+ * @wiphy: The wiphy to check.
+ *
+ * Return: true is 40MHz is disabled in 2.4G band.
+ */
+bool wiphy_is_40mhz_24ghz_disabled(struct wiphy *wiphy);
Why should that have a wiphy argument?
It is up to cfg80211 to determine the logic behind the function. It is
just context supplied by the caller. The fact that it is determined by a
module parameter is internal cfg80211 stuff.
I just don't really see any way it would ever be per wiphy?
Maybe you are right. By the way, is OBSS support a requirement to do
40MHz in 2.4G?
Might also be simpler to just export the variable?
Either way is pretty simple I guess.
Yeah, dunno. I guess exporting the function at least makes sure nobody
will try to set the variable, so that's somewhat useful...
I'd prefer to remove the wiphy argument though (and fix the kernel-doc)
No problem. Will do.
Gr. AvS
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
