On Tue, 2014-06-24 at 19:11 +0200, Arend van Spriel wrote:
> >> + if (wiphy_is_40mhz_24ghz_disabled(wiphy) == false) {
> >> + err = brcmf_enable_bw40_2g(ifp);
> >> + if (!err)
> >> + err = brcmf_fil_iovar_int_set(ifp, "obss_coex",
> >> + BRCMF_OBSS_COEX_AUTO);
> >> + }
> >
> > This seems to have an effect only on the device, so why not do it after
> > wiphy_register()?
>
> It does affect channels list in brcmf_update_wiphybands().
Ah, ok, I guess I missed that.
> Digging further in this code, I found that the brcmf_update_wiphybands()
> queries the device to get the actual list of channels, which
> subsequently is determined by the 40MHz setting in the 2G band. Not so
> much for the channel itself as for the flags. If that is all done after
> wiphy_apply_custom_regulatory() it does not show up when doing 'iw phy
> info'. And according to the documentation that call needs to be done
> before wiphy_register().
>
> In the current code the wiphy_apply_custom_regulatory() is called twice
> (before and after wiphy_register()) which seems to do the trick, but in
> that it might be exploiting unintended behaviour. Hence the attempt to
> change the order of things.
Ok :)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
