On Tuesday 10 June 2014 23:31:37 Rickard Strandqvist wrote: > I guess it's ok to do the patches? Right, you got some feedback from me and another person. You can send patches whenever you like. > But then again, I will then send them one by one, with the cover > letter? +35 email? Have you seen my other reply? Use git-format-patch --cover-letter. Why would you need 35 mails? A commit should logically group a change per driver. So, one commit probably touches rtlXXXX/reg.h and rtlXXXX/hw.c (perhaps others? grep for it!) Be sure to manually check each change. Your last patchset included non-sensial commit messages and subjects. > Then the macro I should add in all the: > > net/wireless/rtlwifi/rtl****se/reg.h > > > And in the: > drivers/staging/rtl8188eu/include/rtl8188e_spec.h > drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h > drivers/staging/rtl8712/rtl871x_wlan_sme.h > drivers/staging/rtl8723au/include/rtl8723a_spec.h > drivers/staging/rtl8821ae/rtl8821ae/reg.h The staging drivers will be taken by Greg KH, see MAINTAINERS for the addresses for staging drivers. > And should I put it like: > #define MSR_MASK 0x03 > > Or is this more accurate: > #define MSR_MASK (MSR_INFRA | MSR_ADHOC) Since the integer resulting from the mask is a decimal sequence rather than a bitmap, it makes more sense to use 0x03 instead. Please have a look at the drivers and be sure to understand why the changes are needed. Peter PS. please do not top-post. For driver discussions, you should keep the list cc'd too. That makes it more likely for someone to respond to such queries. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
