On Mon, 2014-06-09 at 11:17 +0200, Johannes Berg wrote: > On Mon, 2014-06-09 at 10:21 +0300, Luca Coelho wrote: > > > > I think you need to make sure all stop/wake calls are balanced > > > everywhere (including device drivers). Otherwise you risk breaking > > > things silently in some cases. > > > Checking this might be tricky, actually, since I think there are some > > assumptions that stopping a queue that is already stopped is a NOP, but > > now we add to the refcount... > > I don't think we can force drivers to keep track of this, we'll have to > keep the API without refcounting for drivers, I'd say. Yeah, I was thinking in the same terms... Even for mac80211 might be a bit tricky to do it. Maybe I could keep the old APIs as is (ie. they wake the queues no matter what the refcount is) and make the new ieee80211_stop/wake_vif_queues() refcounted? -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
