> So this is the updated patch.
> If you agree, we could push it for merge :)
Yeah, looks fine. Minor code style comments below:
> +static inline int at76_guess_freq(struct at76_priv *priv)
> +{
> + size_t el_off;
should have tabs for indentation
> + const u8 *el;
> + int channel = priv->channel;
> + int len = priv->rx_skb->len;
> + struct ieee80211_hdr *hdr = (void *)priv->rx_skb->data;
> +
> + if (!priv->scanning)
> + goto exit;
> +
> + if (len < 24)
> + goto exit;
> +
> + if (ieee80211_is_probe_resp(hdr->frame_control)) {
> + el_off = offsetof(struct ieee80211_mgmt, u.probe_resp.variable);
> + el = ((struct ieee80211_mgmt *)hdr)->u.probe_resp.variable;
> + } else if (ieee80211_is_beacon(hdr->frame_control)) {
> + el_off = offsetof(struct ieee80211_mgmt, u.beacon.variable);
> + el = ((struct ieee80211_mgmt *)hdr)->u.beacon.variable;
> + } else
> + goto exit;
should have braces around all branches
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
