Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes: > On 06/03/2014 05:14 PM, Ben Hutchings wrote: >> On Sun, 2014-01-19 at 23:35 +0000, Ben Hutchings wrote: >>> On Thu, 2014-01-02 at 18:42 -0600, Larry Finger wrote: >>>> This firmware is for a driver that will soon be submitted to the kernel. >>>> It occurs as data statements in Realtek driver >>>> rtl8723A_WiFi_linux_v4.1.3_6044.20121224. >>>> >>>> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> >>>> --- >>>> WHENCE | 13 +++++++++++++ >>>> rtlwifi/rtl8723aufw_A.bin | Bin 0 -> 22172 bytes >>>> rtlwifi/rtl8723aufw_B.bin | Bin 0 -> 24118 bytes >>>> rtlwifi/rtl8723aufw_B_NoBT.bin | Bin 0 -> 19200 bytes >>>> 4 files changed, 13 insertions(+) >>>> create mode 100644 rtlwifi/rtl8723aufw_A.bin >>>> create mode 100644 rtlwifi/rtl8723aufw_B.bin >>>> create mode 100644 rtlwifi/rtl8723aufw_B_NoBT.bin >>> [...] >>> >>> Applied, thanks. >> >> I just noticed that the driver in Linux 3.15 seems to ask for >> rtlwifi/rtl8723aufw.bin and not rtlwifi/rtl8723aufw_A.bin. You'll need >> to change the filename on one side or the other. > > Jes, > > As Ben points out, I messed up the firmware names, and one of them > needs to be changed. Keeping the name "rtlwifi/rtl8723aufw_A.bin" > would retain a certain amount of symmetry, but is may be easier to > retain "rtlwifi/rtl8723aufw.bin" in the code. A third option would be > to try for one of the names and fall back to the other if it > fails. What do you think? > > In any case, we need additional MODULE_FIRMWARE macros for the other > two firmware files. I'd opt for keeping the _A filename in place. It's for the rev A chip, and I haven't had any complaints for the current code failing due to the naming, so unlikely that a lot of people are trying to use it. I'll change the name in the code here and submit it with my next changeset. I'll add the MODULE_FIRMWARE bits with it. Cheers, Jes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
