Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 25 May 2014 09:53, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Michal Kazior <michal.kazior@xxxxxxxxx> writes: >> >>> This prevents leaving incomplete scatter-gather >>> transfer on CE rings which can lead firmware to >>> crash. >>> >>> Reported-By: Avery Pennarun <apenwarr@xxxxxxxxx> >>> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> >> >> The title is a bit misleading as usually the commit log with the word >> revert means that the commit is reverting another git commit. Maybe >> something like this is better: >> >> ath10k: drop incomplete scatter-gather pci tx transfers > > Good point. I was actually thinking 'abort' .. 'properly'. Sounds good to me. >>> +err: >>> + for (; i > 0; i--) >> >> Isn't this just a fancy way to say 'while (i-- > 0)'? > > Not really. More like do { .. } while (--i > 0), no? First iteration > must use unmodified `i`. Ok, I missed that. Then the for loop is good here. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html