Search Linux Wireless

Re: [PATCH v6 1/6] mac80211: introduce switch_vif_chanctx op

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23 May 2014 10:51, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Fri, 2014-05-23 at 08:09 +0200, Michal Kazior wrote:
>
>> >> +#define IEEE80211_MAX_NUM_SWITCH_VIFS 8
>> >
>> > :-)
>> >
>> > That seems artificial though - why not dynamically allocate?
>>
>> I tend to avoid dynamic allocations whenever I can. I can make it
>> dynamic if you want.
>
> I'm just thinking that Ben Greear will invariably complain about this
> limit ;-)

I see your point now.. :D


>> I think I've had the same problem when I was trying to make a
>> single-call multi-vif csa tracing. Is using dynamic_array for this
>> really doable? I haven't found any code in the kernel using
>> __dynamic_array for anything but simple scalars and buffers.
>
> You could either use multiple arrays, or I guess you could even pack a
> struct into the array, no?

Packing is not a problem - reading/using is. How do you print an array
of structs in a trace? I think I've played around this a little but
gave up for some reason I don't remember anymore.


Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux