Michal Kazior <michal.kazior@xxxxxxxxx> writes: >>> --- a/drivers/net/wireless/ath/ath10k/pci.c >>> +++ b/drivers/net/wireless/ath/ath10k/pci.c >>> @@ -2758,8 +2758,6 @@ static void ath10k_pci_remove(struct pci_dev *pdev) >>> if (!ar_pci) >>> return; >>> >>> - tasklet_kill(&ar_pci->msi_fw_err); >> >> Why this? That's not obvious to me. > > It might end up not being initialized: If you, say, quickly insert and > eject a device you might not even initialize the tasklet (it's done > elsewhere; I suppose we could move it too) before ath10k_pci_remove() > is called. Also the tasklet is already killed elsewhere on the > teardown code path. > > I'll split it into a separate patch that simply removes this line as > it's meaningless to call it here in the first place. Yeah, it's a good idea to have a separate patch for this. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
