On Tue, May 20, 2014 at 11:44 AM, Luis R. Rodriguez
<mcgrof@xxxxxxxxxxxxxxxx> wrote:
> On Sun, May 11, 2014 at 1:50 AM, Emmanuel Grumbach
> <emmanuel.grumbach@xxxxxxxxx> wrote:
>> From: Arik Nemtsov <arik@xxxxxxxxxx>
>>
>> Define a new wiphy callback allowing drivers to provide regulatory
>> settings.
>>
>> Only The first wiphy registered with this callback will be able to provide
>> regulatory domain info. If such a wiphy exists, it takes precedence over
>> other data sources.
>>
>> Change-Id: I7c7e368e200c1414b53e3a86e131de24adc62b93
>> Signed-off-by: Arik Nemtsov <arikx.nemtsov@xxxxxxxxx>
>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
>> ---
>> include/net/cfg80211.h | 17 +++++++++++++
>> net/wireless/reg.c | 65 +++++++++++++++++++++++++++++++++++++++++++++-----
>> 2 files changed, 76 insertions(+), 6 deletions(-)
>>
>> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
>> index f2c3186..3c96b62 100644
>> --- a/include/net/cfg80211.h
>> +++ b/include/net/cfg80211.h
>> @@ -3008,6 +3008,23 @@ struct wiphy {
>> void (*reg_notifier)(struct wiphy *wiphy,
>> struct regulatory_request *request);
>>
>> + /*
>> + * Indicates this wiphy can provide regulatory information.
>> + * Must be set before the wiphy is registered. Only the first
>> + * wiphy with this callback will be called to provide a regdomain
>> + * on country-code changes. The alpha2 in the returned regdomain
>> + * information can be different from the one given via argument,
>> + * if the argument contains the "99" alpha2, meaning unknown.
>> + * If an ERR_PTR is returned the regulatory core will consult other
>> + * sources for the regdomain info (internal regdb and CRDA).
>> + * Returning NULL will cause the regdomain to remain the same.
>> + * The callee will return a struct allocated with kmalloc(). After
>> + * the struct is returned, the regulatory core is responsible
>> + * for freeing it.
>> + */
>
> Use kdoc instead of this long documentation blob.
Sure.
>
>> + struct ieee80211_regdomain * (*get_regd)(struct wiphy *wiphy,
>> + const char *alpha2);
>> +
>> /* fields below are read-only, assigned by cfg80211 */
>>
>> const struct ieee80211_regdomain __rcu *regd;
>
> The driver should be able to dump a regdomain it needs when it needs
> it and use the internal callbacks wiphy_apply_custom_regulatory()
> which tons of drivers already use when it needs to upon
> initialization. As for country IE data you can ignore country IEs,
> there's a flag for this, and do what you want on firmware just as that
> crappy non-upstream vendor qualcomm driver does. Apart from that its
> unclear in this patch why instead any delta observed on wireless-regdb
> is addressed publicly I'd like for this to be considered as a sane
> alternative. Additionally keeping regulatory data in firmware is very
> bug prone and it also doesn't let us grow mature the architecture on
> cfg80211, Intel's firmware has historically only had a few world
> regulatory domains, and historically this is why not much
> contributions from Intel have gone into wireless-regdb, if there is a
> need to support specific countries now on firmware I'd encourage the
> firmware bloat strategy to be seriously reconsidered in light of the
> issues that could arise.
The wiphy_apply_custom_regulatory() option is to be used before
registering the wiphy. We want to be able to accept country code
changes at runtime, with the driver supplying the regdomain.
As for why this was chosen - I think you're barking up the wrong tree :)
The regulatory folks at Intel decided to store the data in FW, I don't
have any say here. I think this is more legal than technology reasons.
Would this patch be acceptable with the documentation changed to kdoc format?
Again, this is a different way of doing things, but it's largely
compatible to the way reg.c already works.
Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
