On 20 May 2014 09:10, Antonio Quartulli <antonio@xxxxxxxxxxxxxx> wrote: > On 20/05/14 09:09, Rafał Miłecki wrote: >> On 20 May 2014 08:48, Antonio Quartulli <antonio@xxxxxxxxxxxxxx> wrote: >>> On 20/05/14 08:46, Rafał Miłecki wrote: >>>> --- a/drivers/net/wireless/b43/xmit.c >>>> +++ b/drivers/net/wireless/b43/xmit.c >>>> - if (phy->type == B43_PHYTYPE_A) >>>> + if (!phy->gmode) >>>> mac_ctl |= B43_TXH_MAC_5GHZ; >>> >>> I am not familiar with this driver, but wouldn't 11b mode fall in this >>> case as well ? >> >> What Broadcom calls a "gmode" is 2GHz. So this is a simple bool >> 1) gmode = true; // we work in 2GHz mode >> 2) gmode = false; // we work in 5GHz mode > > Oh ok, thanks for the clarification! I think the variable name should be > less ambiguous then, but it's your/broadcom code :) You're probably right. It's just a bit historical, it matches bcm47xx specs, Broadcom's public code, Broadcom headers and probably their internal specs. That's why I didn't decide to really touch it, to avoid confusion when comparing specs with the code. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
