Search Linux Wireless

Re: [ath9k-devel] [PATCH] ath9k_htc: use 'struct ath_htc_rx_status *' in call to ath9k_htc_err_stat_rx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 19.05.2014 23:07, schrieb John W. Linville:
>   CC [M]  drivers/net/wireless/ath/ath9k/htc_drv_txrx.o
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c: In function ‘ath9k_rx_prepare’:
> drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:1006:2: warning: passing argument 2 of ‘ath9k_htc_err_stat_rx’ from incompatible pointer type [enabled by default]
>   ath9k_htc_err_stat_rx(priv, &rx_stats);
>   ^
> In file included from drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:17:0:
> drivers/net/wireless/ath/ath9k/htc.h:380:20: note: expected ‘struct ath_htc_rx_status *’ but argument is of type ‘struct ath_rx_status *’
>  static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv,
> 
> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> ---
> Compile-test only...seems reasonable?

Hm... that is incorrect. Some missing patch?
"[PATCH 06/10] ath9k & ath9k_htc: move ath_rx_stats to cmn" did correct
change.
your patch will brake it.




> 
>  drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index bb86eb2ffc95..c1490ddc2965 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -1003,7 +1003,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
>  	/* Copy everything from ath_htc_rx_status (HTC_RX_FRAME_HEADER).
>  	 * After this, we can drop this part of skb. */
>  	rx_status_htc_to_ath(&rx_stats, rxstatus);
> -	ath9k_htc_err_stat_rx(priv, &rx_stats);
> +	ath9k_htc_err_stat_rx(priv, rxstatus);
>  	rx_status->mactime = be64_to_cpu(rxstatus->rs_tstamp);
>  	skb_pull(skb, HTC_RX_FRAME_HEADER_SIZE);
>  
> 


-- 
Regards,
Oleksij

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux