Search Linux Wireless

Re: [RFC] mac80211: handling Qdisc issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +#if TODO
> > +Is this correct??
> > +#endif
> > +	rt2x00lib_write_tx_desc(rt2x00dev, skb, control, queue->qid);
> 
> This is incorrect, even though it theoretically would work.
> The qid != queue number, for most TX queues the value will be the same,
> but the meaning of the field is different.

Hence my #if TODO which causes sparse to warn about the code :) I meant
to ask you but never had time to continue working on this patch.

> Resolving this issue will also be something I can fix relatively fast after this
> patch is accepted and applied to wireless-testing.

You could also just make a patch for exactly this and ask Ron to merge
it together with this?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux