On 05/16/2014 06:18 AM, Kalle Valo wrote:
greearb@xxxxxxxxxxxxxxx writes:
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Check vdev map has space before calling ffs,
fix invalid cleanup in failure to create vdev
case.
Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Why? What motivated you to write this? If you saw a bug, it would be
good to document the bug in the commit log.
This is compile-tested only.
It's two weeks since you posted this, sorry for taking so long. But have
you managed to test this by now?
The code is cleaner with my patch, and it makes it easier to
use the 64-bit version of ffs.
I have tested this extensively in my tree with the 64-bit version
of ffs so that I can have more than 32 vdevs.
It does fix a problem I found through code inspection as well,
when it did not properly release a slot in a failure path.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
