On Thu, 2014-05-15 at 09:51 +0000, Coelho, Luciano wrote: > On Thu, 2014-05-15 at 11:39 +0200, Johannes Berg wrote: > > On Thu, 2014-05-15 at 12:28 +0300, Eliad Peller wrote: > > > On Wed, May 14, 2014 at 5:42 PM, Johannes Berg > > > <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > On Wed, 2014-05-14 at 13:25 +0200, Janusz Dziedzic wrote: > > > >> After patch: > > > >> cfg80211/mac80211: refactor cfg80211_chandef_dfs_required() > > > >> > > > >> start_radar_detection always fail with -EINVAL. > > > > > > > > Applied, thanks. > > > > > > > probably a bit late, but i don't really see why passing > > > NL80211_IFTYPE_UNSPECIFIED at all, instead of the iftype? > > > > I did briefly wonder about the same, but decided Luca probably knew > > better :) > > Actually I also thought the same thing, but had the impression that > there were cases when we wouldn't have the iftype when calling this. > But now I checked both cases where we use NL80211_IFTYPE_UNSPECIFIED and > it seems that we really don't need it. > > I'll send a patch to fix this and revert Janusz's change (unless > Johannes wants to rebase the mac80211-next tree). Instead of just reverting Janusz's patch, I'll make cfg80211_chandef_dfs_required() WARN if UNSPECIFIED is passed. -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
