Michal Kazior <michal.kazior@xxxxxxxxx> writes:
> On 17 April 2014 02:42, <greearb@xxxxxxxxxxxxxxx> wrote:
>> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>>
>> And check for null pool in the tx path (which would
>> indicate we are detaching).
>
> Shouldn't we just make sure tx is stopped before we try to detach htt?
> Stoping mac80211 queues and synchronize_net() should be sufficient I
> think.
>
>
>> @@ -403,6 +412,13 @@ int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *msdu)
>> goto err;
>>
>> spin_lock_bh(&htt->tx_lock);
>> +
>> + /* Check if we are detached... */
>> + if (! htt->tx_pool) {
>> + spin_unlock_bh(&htt->tx_lock);
>
> Setting `res` would be nice to indicate an error. And there's a space after !.
Ben, are you planning to send v2? Or what should we do with this patch?
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
