On Wed, May 07, 2014 at 10:15:53PM +0200, Felix Fietkau wrote: > On 2014-05-07 21:54, John W. Linville wrote: > > On Wed, May 07, 2014 at 09:22:58AM +0200, David Herrmann wrote: > >> ah->caldata may be NULL if no channel is selected. Check for that before > >> accessing it. > >> > >> Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxx> > >> --- > >> Hi > >> > >> This is _definitely_ only a workaround, given that no-one guarantees ah->caldata > >> is freed while we run in hw_per_calibration(). However, this patch fixes serious > >> kernel panics with wifi-P2P on my machine. > >> > >> I'm not sure why ah->caldata can be NULL, but it definitely is. I think the > >> correct fix would be to synchronously stop any running hw-calibration before > >> setting ah->caldata to NULL. I don't know whether/where that is done, so I wrote > >> this small workaround. > >> > >> Thanks > >> David > > > > Is there any hope for getting a more complete fix from the ath9k guys > > in short order? > This looks easy to fix. I'll send a patch soon. Ping? -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
