On Fri, 2014-05-09 at 15:58 +0530, Rajkumar Manoharan wrote:
> +static bool cfg80211_is_all_countryie_ignore(void)
> +{
> + struct cfg80211_registered_device *rdev;
> + struct wireless_dev *wdev;
> +
> + list_for_each_entry(rdev, &cfg80211_rdev_list, list) {
> + list_for_each_entry(wdev, &rdev->wdev_list, list) {
> + wdev_lock(wdev);
> + if (!(wdev->wiphy->regulatory_flags &
> + REGULATORY_COUNTRY_IE_IGNORE)) {
> + wdev_unlock(wdev);
The locking here seems completely pointless.
Also, maybe you can do something about the long lines, maybe with a
temporary variable?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
