Search Linux Wireless

Re: [PATCH] rfkill-gpio: Use gpio cansleep version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2014-05-06 at 18:14 +0200, Loic Poulain wrote:

> +	if (gpiod_cansleep(rfkill->shutdown_gpio))
> +		gpiod_set_value_cansleep(rfkill->shutdown_gpio, !blocked);
> +	else
> +		gpiod_set_value(rfkill->shutdown_gpio, !blocked);
> +
> +	if (gpiod_cansleep(rfkill->reset_gpio))
> +		gpiod_set_value_cansleep(rfkill->reset_gpio, !blocked);
> +	else
> +		gpiod_set_value(rfkill->reset_gpio, !blocked);

Really? I mean, there's not even a fallback where the cansleep() API
calls the non-sleeping one if the cansleep isn't support? This is really
ugly.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux