On 6 May 2014 16:43, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 2014-04-09 at 15:45 +0200, Michal Kazior wrote: >> Channel switch finalization is now 2-step. First >> step is when driver calls chswitch_done(), the >> other is when reservation is actually finalized >> (which be defered for in-place reservation). >> >> It is now safe to call ieee80211_chswitch_done() >> more than once. >> >> Also remove the ieee80211_vif_change_channel() >> because it is no longer used. > > A lot of this looks really duplicated from the previous patch - since I > just merged the fixes is there really a need to go through the work etc. > and have this different, instead of going through cfg80211 for the > disconnect? I'm not really sure what duplication you refer to? There were already a couple of uses of csa_connection_drop_work so I used it too. It might make sense now to use cfg80211_stop_iface() instead but I'd argue it's better to do that as a follow up patch. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html