On Wed, 2014-04-09 at 15:45 +0200, Michal Kazior wrote:
> Channel switch finalization is now 2-step. First
> step is when driver calls csa_finish(), the other
> is when reservation is actually finalized (which
> be defered for in-place reservation).
"which be defered"? should that be "can be"?
> + if (sdata->reserved_chanctx) {
> + /*
> + * with multi-vif csa driver may call ieee80211_csa_finish()
> + * many times while waiting for other interfaces to use their
> + * reservations
> + */
> + if (sdata->reserved_ready)
> + return 0;
> +
> + err = ieee80211_vif_use_reserved_context(sdata);
> + if (err)
> + return err;
> +
> + return 0;
> }
>
> + if (!cfg80211_chandef_identical(&sdata->vif.bss_conf.chandef,
> + &sdata->csa_chandef))
> + return -EINVAL;
> +
> sdata->vif.csa_active = false;
Should csa_active really stay true in the reserved_chanctx case?
Wouldn't that leave it beaconing, with potentially suddenly negative
(due to underflow) CSA counter, or something?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
