Bing Zhao <bzhao@xxxxxxxxxxx> writes:
> From: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
>
> Firmware dump feature is added for PCIe based chipsets.
> Separate file will be created at /var/log/fw_dump_*
> for each memory segment.
>
> Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> Signed-off-by: Bing Zhao <bzhao@xxxxxxxxxxx>
Sorry for commenting so late, I was on holidays and then got lagged
behind with email.
> + memset(filename, 0, sizeof(filename));
> + memcpy(filename, name_prefix, strlen(name_prefix));
> + strcat(filename, entry->mem_name);
> + do_gettimeofday(&t);
> + entry->file_mem = filp_open(filename, O_CREAT | O_RDWR,
> + 0644);
> + if (IS_ERR(entry->file_mem)) {
> + dev_info(adapter->dev,
> + "Create %s file failed at %s, opening another dir /tmp\n",
> + entry->mem_name, filename);
> + memset(filename, 0, sizeof(filename));
> + sprintf(filename, "%s%s", "/tmp/fw_dump_",
> + entry->mem_name);
> + entry->file_mem =
> + filp_open(filename,
> + O_CREAT | O_RDWR, 0644);
> + }
> + if (!IS_ERR(entry->file_mem)) {
> + dev_info(adapter->dev,
> + "Start to save the output : %u.%06u, please wait...\n",
> + (u32)t.tv_sec, (u32)t.tv_usec);
Like I said in my previous email, IMHO a wireless driver should not save
any files to the filesystem. For example, I don't see any other uses of
filp_open() in drivers/net. Ugly hacks like this belong to staging
drivers, not to proper upstream drivers.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
