Search Linux Wireless

Re: [PATCH 2/2] cfg80211: ignore invalid BSSIDs when looking for BSSes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/04/14 22:39, Johannes Berg wrote:
> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index 7d09a712cb1f..746c56ebd66c 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -540,6 +540,8 @@ struct cfg80211_bss *cfg80211_get_bss(struct wiphy *wiphy,
>  			continue;
>  		if (channel && bss->pub.channel != channel)
>  			continue;
> +		if (!is_valid_ether_addr(bss->pub.bssid))
> +			continue;

Wouldn't it be better to prevent such entry to end up in the bss list at
all? (i.e. filtering during the scan?)


Cheers,


-- 
Antonio Quartulli

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux