Search Linux Wireless

Re: [PATCH 2/3] ath10k: don't wait for device init if it crashed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michal Kazior <michal.kazior@xxxxxxxxx> writes:

> When warm resetting it's possible for device to
> crash during initialization. Instead of waiting 3
> seconds just return failure as soon as
> FW_IND_EVENT_PENDING is set.
>
> This speeds up device bootup and recovery in some
> cases.
>
> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>

[...]

> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -2452,6 +2452,9 @@ static int ath10k_pci_wait_for_target_init(struct ath10k *ar)
>  		if (val == 0xffffffff)
>  			continue;
>  
> +		if (val & FW_IND_EVENT_PENDING)
> +			break;

Can you add a small comment here explaining why we do this? "device has
most probably crashed" or something like that.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux