On Wed, 2014-04-09 at 14:46:50 +0200, Johannes Berg wrote: > On Wed, 2014-04-09 at 09:28 +0800, Zhao, Gang wrote: >> Function cfg80211_wext_freq() is declared in wext-compat.h, but its >> parameter struct wiphy's declaration is not included there. Actually >> the parameter is not used in this function, so change it to normal >> net_device. >> >> The compile warning doesn't show up due to duplicate including, but >> it's worth fixing it. > > Why not just include the right file here? As I said in commit log, that parameter is not used in that function, and all the other functions in wext-compat.h use net_device as their parameters, I don't see any reason why this function should be specific. Although changing the parameter type seems complicated the problem, I think it's the more reasonable way. > > johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
