Search Linux Wireless

Re: [PATCH 8/8] cfg80211: remove unnecessary include clauses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-04-09 at 09:49:30 +0200, Johannes Berg wrote:
> I don't like those last four patches, I'd rather have more includes than
> rely on other headers including headers that we need - that could change
> after all.

As I said in commit log, duplicate including could hide some warnings.

In theory, the possibility of change is equal, either it's a directly
included header or a indirectly included header, and it's more likely to
change to include more, not less. So the change may not cause any
problem.

In other way, the local directory header files may change more
frequently than the header files in include/ directory. Whether it's a
total win to apply the last four patches may be a question, but it's
just amusing to see that lots of lines can be deleted. :-)

>
> johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux