On Mon, 2014-03-31 at 11:57 +0200, Michal Kazior wrote: > It was possible for tx queues to be stuck locked > if AP CSA finalization failed. In that case > stop_ap nor do_stop woke the queues up. This means > it was impossible to perform tx at all until > driver was reloaded or a successful CSA was > performed later. > > It was possible to solve this in a simpler manner > however this is more robust and future proof > (having multi-vif CSA in mind). > > New sdata->csa_block_tx is introduced to keep > track of which interfaces requested tx to be > blocked for CSA. This is required because mac80211 > locks all tx queues for that purpose. This means > queues must be unlocked only when last tx-blocking > CSA interface is finished. > > It is still possible to have tx queues stopped > after CSA failure but as soon as offending > interfaces are stopped from userspace (stop_ap or > ifdown) tx queues are woken up properly. Looks fine, but I agree with Luca regarding locked -> stopped. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
