On 31 March 2014 13:45, Luca Coelho <luca@xxxxxxxxx> wrote: > On Mon, 2014-03-31 at 11:57 +0200, Michal Kazior wrote: >> It doesn't make much sense to leave a cripled >> interface running. >> >> As a side effect this will unblock tx queues with >> CSA reason immediately after failure instead of >> until after userspace requests interface to stop. >> >> This also gives userspace an opportunity to >> indirectly see CSA failure. >> >> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> >> --- > > [...] > >> @@ -3100,7 +3100,7 @@ static void ieee80211_csa_finalize(struct ieee80211_sub_if_data *sdata) >> sdata->radar_required = sdata->csa_radar_required; >> err = ieee80211_vif_change_channel(sdata, &changed); >> if (WARN_ON(err < 0)) >> - return; >> + return err; > > Didn't we agree to remove the WARN_ON() from here? I forgot, sorry. Now I definitely need to respin, again :) Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html