On Thu, 2014-03-20 at 08:12 +0100, Michal Kazior wrote: > On 19 March 2014 15:06, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Wed, 2014-03-05 at 13:14 +0100, Michal Kazior wrote: > >> It was impossible to change chanctx of master AP > >> for AP VLANs because the copy function requires > >> RTNL which can't be simply taken in mac80211 code > >> due to possible deadlocks. > >> > >> This is required for future chanctx reservation > >> that re-bind vifs to new chanctx. This requires > >> safe AP VLAN iteration without RTNL. > >> > >> Now VLANs can be iterated while holding either > >> RTNL or local->mtx because the list is modified > >> while holding both of these locks. > > > > No objection really, but maybe it would make more sense to use > > iflist_mtx? > > I used local->mtx because it seemed easier at the time (the lock is > already used on all related codepaths). > > Using local->iflist_mtx would add another mutex to for > csa/reservation. I think it shouldn't be hard to do it though. Should > I re-spin? (this will probably need a re-spin of Luca's reservation > patchset and my RFC). No, it's fine, I was just curious. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
