On 03/25/2014 05:02 AM, Kalle Valo wrote:
> greearb@xxxxxxxxxxxxxxx writes:
>
>> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>>
>> Make this message more obvious that it is a serious
>> problem (will cause tx flush issues, at least).
>>
>> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>> ---
>>
>> v2: Add this to series, but ordering is not overly important.
>>
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath10k/txrx.c
>> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
>> @@ -58,7 +58,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
>> tx_done->msdu_id, !!tx_done->discard, !!tx_done->no_ack);
>>
>> if (tx_done->msdu_id >= htt->max_num_pending_tx) {
>> - ath10k_warn("warning: msdu_id %d too big, ignoring\n",
>> + ath10k_warn("error: msdu_id %d too big, ignoring\n",
>> tx_done->msdu_id);
>> return;
>> }
>
> To me any warning is a serious matter, I'm not sure how changing this to
> message to use "error:" makes any difference?
To me, warning is bad, but probably not critical. Error would be a failure that
is not (easily) recovered from. In the case above, the result of this problem
would be effectively a reference counting leak that hangs the driver for 5 seconds
(under rtnl lock, I believe) each time the driver tries to flush. This will never
recover until firmware is restarted.
So, I think it is more of an error than warning, but it is not a big deal
either way, so feel free to just drop the patch.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
