On Mon, Mar 24, 2014 at 10:14:06AM -0500, Larry Finger wrote: > On 03/24/2014 06:34 AM, Adam Lee wrote: > >Add MSI interrupts support, enable it when msi_support flag is true, > >also could fallback to pin-based interrupts mode if MSI mode fails. > > > >Signed-off-by: Adam Lee <adam.lee@xxxxxxxxxxxxx> > > Your first patch turns on MSI support unconditionally. That implies that > there are no harmful effects for attempting to use MSI on a box where it is > not needed, and/or not implemented. If that is the case, then the > msi_support bool should be eliminated, your first patch dropped, and this > one revised appropriately. Driver rtl8723be added this bool, but never uses > it. Once that driver reaches mainline, a patch can be prepared to remove the > variable. Hi, Larry Just confirmed with RealTek wireless engineer, their policy is: > Case 1: if the platform supports both MSI and Pin-based, our driver will use MSI. > Case 2: if the platform supports MSI only, our driver will use MSI. > Case 3: if the platform supports Pin-Based only, out driver will use Pin-Based. I think it's safe enough to apply the first "rtlwifi: rtl8188ee: enable MSI interrupts support" patch also, and the msi_support bool should not be eliminated(at least for now) in case some wifi modules don't support MSI well. Thanks. -- Adam Lee -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
