Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: >> drivers/net/wireless/ath/ath10k/debug.c:500 ath10k_write_simulate_fw_crash() error: strncmp() '"hard"' too small (5 vs 32) >> drivers/net/wireless/ath/ath10k/debug.c:497 ath10k_write_simulate_fw_crash() error: strncmp() '"soft"' too small (5 vs 32) >> >> I wanted to use strncmp() instead of strcmp(), but I'm not sure what to >> do here. In my opinion it's guaranteed that the string "hard" is null >> terminated, so it shouldn't matter even if strlen("soft") (5) is less >> than sizeof(buf) (32), right? Or am I missing something here? >> > > I am on vacation until next week. I didn't think these particular > emails went out automatically. Actually that's true. Fengguang's bot sends me a build report after every build and I saw these warnings in that report. > Anyway, I have changed this in the latest smatch but it will take some > months for the kbuild bot to update. > > http://repo.or.cz/w/smatch.git/commitdiff/f10f27a7612c5b1e69b5d9080a0194d012beb6aa > > I'll take a closer look next week. Thanks! -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html