Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 21 March 2014 06:34, Chun-Yeow Yeoh <yeohchunyeow@xxxxxxxxx> wrote: >> Using the macro to convert the MAC address from WMI word >> format to char array has lead to the wrong peer mac >> address printed out while retrieving the peer stats from >> FW. Fix this. >> >> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@xxxxxxxxx> >> --- >> drivers/net/wireless/ath/ath10k/debug.c | 4 ++-- >> drivers/net/wireless/ath/ath10k/wmi.h | 10 ---------- >> 2 files changed, 2 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c >> index 6debd28..f95defa 100644 >> --- a/drivers/net/wireless/ath/ath10k/debug.c >> +++ b/drivers/net/wireless/ath/ath10k/debug.c >> @@ -252,8 +252,8 @@ void ath10k_debug_read_target_stats(struct ath10k *ar, >> peer_stats = (struct wmi_peer_stats *)tmp; >> s = &stats->peer_stat[i]; >> >> - WMI_MAC_ADDR_TO_CHAR_ARRAY(&peer_stats->peer_macaddr, >> - s->peer_macaddr); >> + memcpy(s->peer_macaddr, &peer_stats->peer_macaddr.addr, >> + ETH_ALEN); > > I noticed checkpatch started suggesting to prefer ether_addr_copy() > over memcpy(). Not a big deal though. Yeah, especially that I haven't updated my checkpatch for few months and I don't see this warning yet :) (I'll try to keep ath10k checkpatch clean whenever possible.) We need to switch ath10k to use ether_addr_copy() everywhere in a separate patch anyway. > Other than that the patch looks good. > > Reviewed-By: Michał Kazior <michal.kazior@xxxxxxxxx> Thanks, I added this to the patch. Let's just hope that the l with the extra line doesn't cause any charset problems :) BTW, what is the name of the character? Never seen that before. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
