BTW, is anyone ever tested the get stats for firmware 636 before your patch and getting positive results? --- Chun-Yeow On Sat, Mar 22, 2014 at 12:42 AM, Yeoh Chun-Yeow <yeohchunyeow@xxxxxxxxx> wrote: > Hi, Ben > > I did a quick check again on STA mode. With or without your patch, the > printed peer stats are both identical but both wrong. See below: > > ath10k PEER stats > ================= > > Peer MAC address 00:00:00:00:00:00 > Peer RSSI 256 > Peer TX rate 0 > > Peer MAC address 00:00:00:00:04:f0 > Peer RSSI 17317 > Peer TX rate 73 > > So I think that your patch makes no difference but do indeed providing > "correct" peer stats on latest AP firmware. > > After applying the "ath10k: add the Rx rate in FW stats", I am able to > get the Tx and Rx Rate for all connected STAs to my AP. > > --- > Chun-Yeow > > On Sat, Mar 22, 2014 at 12:12 AM, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Ben Greear <greearb@xxxxxxxxxxxxxxx> writes: >> >>> On 03/20/2014 11:41 PM, Yeoh Chun-Yeow wrote: >>>>> >>>>> Did you test 636 as well? 636 doesn't seem to support more than just `stats_id`. >>>>> >>>> Nope. Tested with 636 not working. >>> >>> Does the existing code work with 636? If so, we can add two different cmd >>> structs and use the smaller one with 636, and the one I modified with >>> 10.x firmware? >> >> For this issue that would be the best approach. See Marek P's patch >> "ath10k: update regulatory domain settings for 10.x firmware" (not yet >> applied, still in ath-next-test branch) as an example how this can be >> done. >> >> -- >> Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html