On 03/20/2014 11:33 PM, Michal Kazior wrote:
> On 21 March 2014 01:05, <greearb@xxxxxxxxxxxxxxx> wrote:
>> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>>
>> Make the request command object the right size so that
>> firmware will not just throw it away.
>> Tested customized and upstream firmware.
>
> Did you test 636 as well? 636 doesn't seem to support more than just `stats_id`.
The firmware source I have checks in such a way that sending too
large of a cmd should be fine, only too small of a command packet
causes it to be ignored.
I do not have the 636 firmware to test against.
>> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>> ---
>> drivers/net/wireless/ath/ath10k/wmi.h | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
>> index fa1b9e0..4946471 100644
>> --- a/drivers/net/wireless/ath/ath10k/wmi.h
>> +++ b/drivers/net/wireless/ath/ath10k/wmi.h
>> @@ -2766,6 +2766,11 @@ enum wmi_stats_id {
>> WMI_REQUEST_AP_STAT = 0x02
>> };
>>
>> +struct wlan_inst_rssi_args {
>> + __le16 cfg_retry_count;
>> + __le16 retry_count;
>> +};
>> +
>> struct wmi_request_stats_cmd {
>> __le32 stats_id;
>>
>> @@ -2773,6 +2778,12 @@ struct wmi_request_stats_cmd {
>> * Space to add parameters like
>> * peer mac addr
>> */
>
> You can probably remove the comment now :-)
Ok, I can do that.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
