On Fri, Mar 14, 2014 at 02:04:51PM -0500, Dan Williams wrote: > On Mon, 2014-03-10 at 20:56 +0530, fariyaf@xxxxxxxxx wrote: > > From: Fariya Fatima <fariyaf@xxxxxxxxx> > > > > This series of patches adds Redpine Signals wireless driver. > > Looking much better, good work. > > One last comment; there are a couple functions (rsi_device_init, > rsi_host_intf_write_pkt) that are defined multiple times, once in the > USB code and once in the SDIO code. These need to be renamed, otherwise > you will not be able to load the USB and the SDIO modules at the same > time. > > I would suggest making all the functions in rsi_usb.h start with > "rsi_usb" if they don't already, and have functions in rsi_sdio.h start > with "rsi_sdio" if they don't already. Good thing I haven't pushed yet... :-) Please make the changes Dan suggests and resubmit...thanks! John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
