On Sat, Feb 22, 2014 at 1:48 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote:
> When passing tx frames to the U-APSD queue for powersave poll responses,
> the ath_atx_tid pointer needs to be passed to ath_tx_setup_buffer for
> proper sequence number accounting.
>
> This fixes high latency and connection stability issues with ath9k
> running as AP and a few kinds of mobile phones as client, when PS-Poll
> is heavily used
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx>
> ---
Hi Felix,
this commit introduced a regression for me when using Intel Win7
clients on a ath9k AP.
I was not able to track the exact issue down yet :( but it seems to be
related to the Intel
client constantly tearing down the BA session and entering/leaving PS mode.
Any idea?
Thanks,
Helmut
> drivers/net/wireless/ath/ath9k/xmit.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
> index 4f4ce83..f042a18 100644
> --- a/drivers/net/wireless/ath/ath9k/xmit.c
> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
> @@ -2186,14 +2186,15 @@ int ath_tx_start(struct ieee80211_hw *hw, struct sk_buff *skb,
> txq->stopped = true;
> }
>
> + if (txctl->an)
> + tid = ath_get_skb_tid(sc, txctl->an, skb);
> +
> if (info->flags & IEEE80211_TX_CTL_PS_RESPONSE) {
> ath_txq_unlock(sc, txq);
> txq = sc->tx.uapsdq;
> ath_txq_lock(sc, txq);
> } else if (txctl->an &&
> ieee80211_is_data_present(hdr->frame_control)) {
> - tid = ath_get_skb_tid(sc, txctl->an, skb);
> -
> WARN_ON(tid->ac->txq != txctl->txq);
>
> if (info->flags & IEEE80211_TX_CTL_CLEAR_PS_FILT)
> --
> 1.8.3.4 (Apple Git-47)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
