On 10 March 2014 21:27, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2014-03-07 at 12:19 +0100, Michal Kazior wrote: >> Channel contexts are implicitly bound to hw >> already so make it possible to dereference it >> through the channel context itself. >> >> This will make it possible to reduce number of >> arguments for chanctx-related functions. > > I don't really see much point in this, is there ever anything where we > really get only a channel context and don't already have the local > pointer? > > With interfaces, at least, we need it because we can get an interface > through e.g. do_stop or do_open, so we don't have an easy way to > reference local, but here? I don't think our functions have so many > arguments that it's worth putting a pointer into the struct instead. It just seems silly to me to pass local+chanctx all the time while chanctx is already implicitly bound to a single hw. I'm okay to drop this though. It's not really important. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
