Hi, > For example rt2x00 devices only have one promiscuous mode that covers traffic > in the same and other BSSes therefore if either of FIF_PROMISC_IN_BSS or > FIF_OTHER_BSS are set then the driver will set both of them in the returned > flags value. > > It will also for some devices set the FIF_ALLMULTI flag if mc_count is non > zero. > > If this behaviour is considered desirable then I'll keep it working when > making the change but if not I'll remove it. Interesting. I don't think I have an opinion right now. I wanted to be strict about clearing the flags so that you don't end up with a flag that we never get traffic for, but I can't imagine any check where you'd want to know "do I get traffic XY". How do you keep track of that anyway? Say somebody enables FIF_PROMISC_IN_BSS and you also set FIF_OTHER_BSS, then when FIF_PROMISC_IN_BSS is disabled again FIF_OTHER_BSS should be disabled too but how know that it wasn't set in the meantime? I think that says that you shouldn't do that... johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
