On Mon, 2014-03-03 at 13:51 +0530, Fariya Fatima wrote:
> +int rsi_mac80211_attach(struct rsi_common *common)
> +{
> + int status = 0;
> + struct ieee80211_hw *hw = NULL;
> + struct wiphy *wiphy = NULL;
> + struct rsi_hw *adapter = common->priv;
> + u8 addr_mask[ETH_ALEN] = {0x0, 0x0, 0x0, 0x0, 0x0, 0x3};
> + struct ieee80211_supported_band *sband = &adapter->sbands[0];
This is pretty odd
> + wiphy->bands[IEEE80211_BAND_2GHZ] = &sband[IEEE80211_BAND_2GHZ];
combined with that.
> + /* wiphy->bands[IEEE80211_BAND_5GHZ] = &sband[IEEE80211_BAND_5GHZ]; */
> +
> + status = ieee80211_register_hw(hw);
> + if (status)
> + return status;
> +
> +#ifdef CONFIG_RSI_DEBUGFS
> + if (rsi_init_dbgfs(adapter)) {
similar comment here like with the teardown.
> + rsi_dbg(ERR_ZONE, "%s: dbgfs not created\n", __func__);
> + return -1;
-1 is also not a good error code, like before
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
