On Wed, Feb 26, 2014 at 7:04 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: >> - gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0); >> + gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0); > > I think the correct fix here is to look up the GPIO by name rather than > by index, but simply hard-code the name rather than generating it with > sprintf(). Index lookups are hard to expand compatibly, but named-based > lookups scale much better. > > In other words, I rather specifically disagree with using a plain > "gpios" property in any future DT binding, but would strongly prefer > e.g. reset-gpios/shutdown-gpios or gpios/gpio-names. If I understand the situation correctly it's like ACPI does not have named GPIOs so keeping specifying this in DT GPIO bindings is counter-productive to the work of abstracting the access to GPIO handlers so that drivers need not know whether ACPI or DT is used for describing the hardware. We could do worse. Like putting the GPIOs in a differently indexed order in DT vs ACPI. I have no strong opinion really, I just see that people doing DT and ACPI HW descriptions need to cooperate if they want to share infrastructure or we have to give up that pipe dream and let each HW description method have its own unique probe()-runpath. Which would be the result in this driver if we persist on using named GPIOs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
