On Tue, Mar 04, 2014 at 09:08:26PM +0100, Jonas Gorski wrote: > On Tue, Mar 4, 2014 at 7:38 PM, John W. Linville <linville@xxxxxxxxxxxxx> wrote: > > Does anyone have any last objections or criticisms to this patch series? > > > On Mon, Mar 03, 2014 at 01:25:38PM +0530, Fariya Fatima wrote: > >> Kconfig | 1 > >> Makefile | 1 > > A minor critique would be that these Kconfig/Makefile changes should > be added in the last patch, else any in-between will result in a state > where the driver is selectable, but fails to build because of missing > source files. FWIW, I tend to collapse a series like this (i.e. one that adds a new driver using a series of small, non-buildable patches) into a single patch when merging. > Also the subject suggests the patch set was based on linus' tree, not > wireless-next (or whatever the correct tree is), but this does not > necessarily mean it does not apply; I did not test this. This is usually not a (big) merge problem for a new driver. John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
