Ben Greear <greearb@xxxxxxxxxxxxxxx> writes:
> On 02/13/2014 10:06 PM, Kalle Valo wrote:
>
>> @@ -1542,20 +1542,20 @@ static int ath10k_station_assoc(struct ath10k *ar, struct ath10k_vif *arvif,
>>
>> ret = ath10k_setup_peer_smps(ar, arvif, sta->addr, &sta->ht_cap);
>> if (ret) {
>> - ath10k_warn("failed to setup peer SMPS: %d\n", ret);
>> + ath10k_warn("failed to setup peer SMPS for vdev: %d\n", ret);
>> return ret;
>> }
>
> Looks like that could use the vdev id in it...I must have missed it on
> my first attempt.
I fix this before I apply the patch.
>> @@ -3252,7 +3252,7 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
>> arvif->vdev_id, sta->addr);
>> ret = ath10k_peer_delete(ar, arvif->vdev_id, sta->addr);
>> if (ret)
>> - ath10k_warn("Failed to delete peer: %pM for VDEV: %d ret %i\n",
>> + ath10k_warn("Failed to delete peer %pM for vdev %d: %i\n",
>> sta->addr, arvif->vdev_id, ret);
>
>
> While you are harmonizing the messages...maybe change all instances of
> "failed to "Failed ?
>
> I wasn't sure what was preferred so I left that alone when doing my patch.
Actually, I'll send a separate patch for this. Easier that way.
> The rest of the changes look fine to me.
Thanks for the review.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
