On 3 March 2014 13:55, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2014-02-28 at 15:58 +0100, Michal Kazior wrote: >> The beacon_interval was set unprotected by >> wdev.mtx. This could possibly lead to inconsistent >> cfg80211 states. > > Why not just this patch? The beacon_interval is already set to 0 in > stop_ap(), and is irrelevant for the other modes. > > diff --git a/net/wireless/core.c b/net/wireless/core.c > index 010892b81a06..a3bf18d11609 100644 > --- a/net/wireless/core.c > +++ b/net/wireless/core.c > @@ -788,8 +788,6 @@ void cfg80211_leave(struct cfg80211_registered_device *rdev, > default: > break; > } > - > - wdev->beacon_interval = 0; > } > > static int cfg80211_netdev_notifier_call(struct notifier_block *nb, > > > johannes Good point. I was focused on locking changes (for my other patch) and noticed the beacon_interval being unprotected and didn't look more into it. Should I respin or are you going to apply your patch yourself? Either way is fine with me. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
