Hi Johannes,
Thanks for reviewing our patch.
> On Thu, 2014-02-27 at 19:35 -0800, Bing Zhao wrote:
> > From: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> >
> > Deauth is sent to AP when the device is acting as station at shutdown
> > time. Similarly we should stop AP operation also.
> > mwifiex_deauthenticate() takes care closing the connection based on
> > provided interface type.
>
> Wouldn't all this be handled by cfg80211 anyway?
It would, but it's too late.
When mwifiex driver gets unloaded, it needs to send BSS_STOP command to firmware and then shut down the firmware. Prior to this patch we rely on .stop_ap handler to send the BSS_STOP command to firmware.
Unfortunately, by the time when .stop_ap handler is called, driver has already shut down the firmware, hence the BSS_STOP command is ignored, leaving the firmware in a unknown state.
This patch makes sure that the BSS_STOP command is sent to firmware explicitly before the shutdown.
Thanks,
Bing
>
> johannes
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
