Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 25 February 2014 08:13, Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> wrote: >> Currently when we check attention flags we do __le32_to_cpu() >> four times for each packet. This could have performance >> impact for BIG endian platforms. This patch improve this >> little bit. >> >> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> [...] >> @@ -929,6 +873,9 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt, >> struct sk_buff *msdu_head, *msdu_tail; >> enum htt_rx_mpdu_status status; >> int msdu_chaining; >> + struct htt_rx_desc *rxd; >> + u32 att_flags; >> + > > No need for an empty line I suppose? I would also prefer `attention` > instead of `att_flags`, but no big deal. Yeah, attention is better. And also the variable declarations should be in the beginning of function. Apparently I have been sloppy missed that here. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
