Hi Johannes, > On Sun, 2014-02-23 at 15:08 +0100, Thomas Huehn wrote: >> Flag IEEE80211_TX_CTL_ASSIGN_SEQ is only used within the tx path while >> ieee80211_tx_info->control is valid. Therefore this patch moves this flag >> from info->flags structure into the info->control.flags and renames it to >> IEEE80211_TX_CTRL_ASSIGN_SEQ. > > I'm not convinced this patch is correct, so you need to convince me. > What happens to software-retry frames? They probably *shouldn't* get a > new seqno, but if the driver doesn't modify the SKB (say because > hardware/firmware assigns it) then this is certainly not right. > As far as I can see, software-retry frames get in status.c the flag IEEE80211_TX_INTFL_RETRANSMISSION assigned (in function ieee80211_handle_filtered_frame). And this flag prevents in function invoke_tx_handlers() the call of ieee80211_tx_h_sequence(), so there is not new seqno assigned in case of a software-retry within tx.c. But in case of a software retry there is info->control set to zero. After I would move IEEE80211_TX_CTL_ASSIGN_SEQ into info->control.flags this flag is zero. Hence also drivers do not assign a new sequence number. Do I miss something here ? Greetings Thomas-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
