Search Linux Wireless

Re: [PATCH v3 2/7] cfg80211: remove radar requirements check from cfg80211_can_use_iftype_chan()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2014-02-20 at 16:36 +0200, Luciano Coelho wrote:
> From: Luciano Coelho <luciano.coelho@xxxxxxxxx>
> 
> We don't have to double check whether the parameters passed to
> cfg80211_can_use_iftype_chan() are correct.  We should just make sure
> they *are* when we call this function.
> 
> Remove the radar_detect argument check in
> cfg80211_can_use_iftype_chan() to simplify the code.

Applied.


>  	check_chan = params->chandef.chan;
> -	if (params->userspace_handles_dfs) {
> -		/* use channel NULL to check for radar even if the current
> -		 * channel is not a radar channel - it might decide to change
> -		 * to DFS channel later.
> +	if (params->userspace_handles_dfs)
> +		/* Check for radar even if the current channel is not
> +		 * a radar channel - it might decide to change to DFS
> +		 * channel later.
>  		 */
>  		radar_detect_width = BIT(params->chandef.width);
> -		check_chan = NULL;
> -	}

but I kept those braces, since the long comment otherwise makes it easy
to get it wrong when changing code.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux