On 02/20/2014 06:55 PM, Chen-Yu Tsai wrote: > Hi, > > On Fri, Feb 21, 2014 at 12:38 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: >> On 02/20/2014 05:51 AM, Heikki Krogerus wrote: >>> There is no use for them in this driver. This will fix a >>> static checker warning.. >> >> Didn't you remove the use: >> >> - gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0); >> + gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0); >> >> doesn't that parameter get put into the sysfs GPIO debug file, so people >> can see which GPIOs are used for what? > > That's correct. However using con_id to pass this results in different > behavior across DT and ACPI. A better way is to export the labeling > function so consumers can set meaningful labels themselves. But this code is the consumer of those GPIOs. IF the parameter to devm_gpiod_get_index() isn't intended to be used, why does it exist? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
