On 20 February 2014 08:51, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Thu, 2014-02-20 at 08:27 +0100, Janusz Dziedzic wrote:
>> On 19 February 2014 23:00, Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx> wrote:
>> > On Tue, Feb 18, 2014 at 10:12 PM, Janusz Dziedzic
>> > <janusz.dziedzic@xxxxxxxxx> wrote:
>> >> 2014-02-19 1:33 GMT+01:00 Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx>:
>> >>> On Wed, Feb 12, 2014 at 9:43 AM, Janusz Dziedzic
>> >>> <janusz.dziedzic@xxxxxxxxx> wrote:
>> >>>> Handle AUTO bandwidth setting in db2rd.
>> >>>> Don't add NL80211_ATTR_FREQ_RANGE_MAX_BW attribute
>> >>>> in case of AUTO bw calculation.
>> >>>>
>> >>>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx>
>> >>>
>> >>> Please elaborate more on this. Who deals with the automatic math on
>> >>> the bandwidth?
>> >>>
>> >> cfg80211,
>> >>
>> >> Please check patch:
>> >> cfg80211: regulatory introduce maximum bandwidth calculation
>> >
>> > OK, so we don't send the max bandwidth attribute now, what about
>> > support for older kernels?
>> >
>> Yes, seems we should send this even this is 0.
>> Next for old kernel, all channels where BW=0 will be HT20 only.
>
> Is that really a good idea?
>
> Maybe crda should just get the logic to determine maximum bandwidth,
> like you did in the kernel, and then we can even revert the kernel code
> again?
>
Yes, this is possible to calculate this in crda (or even set this manually).
In such case we have to remove this bw check in the kernel code:
is_valid_reg_rule(...)
freq_diff = freq_range->end_freq_khz - freq_range->start_freq_khz;
if (freq_range->max_bandwidth_khz > freq_diff)
return false;
BR
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
